Don't Repeat Yourself

add_job.rb

def random_person
  names = %w(Mike Zoe Adam Sarah)
  jobs = %w(Astronaut Engineer Painter Day-Trader Theoretical-Physicist)
  Person.new(random_item(names), random_item(jobs))
end

add_parameter.rb

def random_index(list)
  rand(4)
end

def random_item(list)
  list[random_index(list)]
end

jobs_structure.rb

def random_person
  names = %w(Mike Zoe Adam Sarah)
  jobs = {
    stem: %w(Astronaut Engineer Theoretical-Physicist),
    finance: %w(Day-Trader),
    arts: %w(Painter)
  }
  Person.new(random_item(names), random_item(jobs))
end

pets.rb

def random_person
  # ...
  pets = [
    { type: 'Dog', name: 'Fido'},
    { type: 'Cat', name: 'Whiskers' },
    { type: 'Horse', name: 'Thunder' }
  ]
  Person.new(random_item(names), random_item(jobs), random_item(pets))
end

random.rb

class Person
  def initialize(name, job)
    @name = name
    @job = job
  end

  def to_s
    "Person named #{@name}, works as a #{@job}"
  end
end

def random_person
  names = %w(Mike Zoe Adam Sarah)
  jobs = %w(Astronaut Engineer Painter Day-Trader)
  Person.new(names[rand(4)], jobs[rand(4)])
end

def main
  10
    .times
    .collect { random_person }
    .each { |p| puts p }
end

main

random_index.rb

def random_index
  rand(4)
end

def random_person
  names = %w(Mike Zoe Adam Sarah)
  jobs = %w(Astronaut Engineer Painter Day-Trader)
  Person.new(names[random_index], jobs[random_index])
end

random_item.rb

def random_item(list)
  list[random_index]
end

def random_person
  names = %w(Mike Zoe Adam Sarah)
  jobs = %w(Astronaut Engineer Painter Day-Trader)
  Person.new(random_item(names), random_item(jobs))
end

replace_algorithm_index.rb

def random_index(list)
  rand(list.size)
end

type_checking.rb

def random_item(list)
  if list.is_a?(Array)
    list[random_index(list)]
  else
    jobs = list.map {|_, values| values}.flatten
    jobs[random_index(jobs)]
  end
end