Wanting opinions on the each method. Am I doing this right?

timeframe.rb

class Timeframe
  include Enumerable

  attr_accessor :start_time, :end_time

  ONEDAY = 24 * 60 * 60

  def initialize(start_time, end_time)
    @start_time = start_time
    @end_time = end_time
  end

  def each
    @current_time = @start_time
    while @current_time <= @end_time
      yield @current_time
      @current_time += ONEDAY
    end
  end
end

@johnkary I'm just in the lazy habit of using attr_accessor. I'm a horrible person.

@KellyMahan The #each method is a special method used by the Enumerable module. When you define each in a class in which Enumerable has been included, you get instant access to most of Enumerable's methods (in this case, I wanted map).

But you're right, each_day would be much better, and so I think changing the name of the class might make each make a little more sense. I may change it to Daterange or Dayrange. Not sure.

Really appreciate the feedback.