Skip to content

Instantly share code, notes, and snippets.

View ValuedMammal's full-sized avatar

ValuedMammal

View GitHub Profile
@ValuedMammal
ValuedMammal / review-club-337-answers.md
Last active March 13, 2026 18:09
Review #337 - Don't fail in `build_fee_bump` for missing parent txid

Review #337 Q&A

  1. Did you review the PR, what did you think (ACK, NACK, etc)? What was your review process?
  2. What is the use case for the TxBuilder::add_foreign_utxo API? (1 pt)
    ans: The normal TxBuilder::add_utxo only accepts wallet UTXOs that are unspent, but there are times when we might want to include inputs from other wallets if building transactions collaboratively with other parties. For that we have add_foreign_utxo.
  3. What is Wallet::build_fee_bump designed to accomplish? Briefly describe the high-level steps (2 pt)
    ans: build_fee_bump takes a transaction ID representing the tx to be fee-bumped (via RBF) and returns a new TxBuilder populated with the parameters of the original transaction (version, recipients, etc).
    Steps:
  • Retrieve the original transaction data from the wallet
@ValuedMammal
ValuedMammal / merge-chains-flow.md
Last active February 18, 2026 16:26
Merge chains flowchart

Merge chains logical flow

Rules

Section A (main loop)

  1. Iterate both original and update chains backward from the tip
  2. If both are None goto B
  3. Compare heights
    • If the update is greater, add to changeset, and advance the update chain
    • If the original is greater, mark the original block ID as potentially invalid, and advance the original chain
@ValuedMammal
ValuedMammal / review-club-2038.md
Last active February 3, 2026 16:06
Review club `bdk` #2038

Review club bdk #2038

Topic: Replace CanonicalIter with sans-IO CanonicalizationTask
Meeting: 2026-01-29 at 13:00 UTC on Discord
PR: bitcoindevkit/bdk#2038
Author: @oleonardolima

Commits

  • 997a460d - refactor(chain)!: replace CanonicalIter with sans-io CanonicalizationTask