LalatenduMohanty

--test-mode Design Document

Table of Contents

1. Overview
2. Problem Statement
3. Design Goals
4. Architecture
5. Implementation Details
6. API Design
7. Error Handling

LalatenduMohanty

# Fromager --test-mode Implementation - Exact Conversation Transcript

## Initial User Request
**User**: Introduce a test-mode ( a cli flag) to the bootstrap command. it should build packages similar to an usual bootstrap command. However if it fails to build a package it should should mark it as pre-built and rerun the bootstrap. It should continue doing it till it goes through all the packages. At the end the command should produce a list of the packages with build failures and exit with an error code indicating that the build did not succeed. Use existing code patterens in the repo to write this code. Also do not write the tests.

**Assistant**: I'll implement the `--test-mode` CLI flag for the bootstrap command that handles build failures by marking failed packages as pre-built and continuing the process. Let me analyze the existing code structure and implement this feature.

[Assistant created todo list and implemented the test mode with multiple code changes to src/fromager/commands/bootstrap.py]

**Ass

LalatenduMohanty

ARG IMAGE=kindest/node
ARG VERSION=1.19
ARG MINOR=1
ARG OS=xUbuntu_20.04

FROM ${IMAGE}:v${VERSION}.${MINOR}

ARG VERSION
ARG OS

LalatenduMohanty

curl --silent --header 'Accept:application/json' 'https://api.openshift.com/api/upgrades_info/v1/graph?arch=amd64&channel=candidate-4.8' | jq '. as $graph | $graph.nodes | map(.version == "4.8.7") | index(true) as $orig | $graph.edges | map(select(.[0] == $orig)[1]) | map($graph.nodes[.])'
[
  {
    "version": "4.8.28",
    "payload": "quay.io/openshift-release-dev/ocp-release@sha256:ba1299680b542e46744307afc7effc15957a20592d88de4651610b52ed8be9a8",
    "metadata": {
      "io.openshift.upgrades.graph.release.channels": "eus-4.10,candidate-4.8,eus-4.8,fast-4.8,stable-4.8,candidate-4.9,fast-4.9,stable-4.9",
      "io.openshift.upgrades.graph.release.manifestref": "sha256:ba1299680b542e46744307afc7effc15957a20592d88de4651610b52ed8be9a8",
      "url": "https://access.redhat.com/errata/RHBA-2022:0172"
    }

LalatenduMohanty

#!/bin/bash

set -eu

root="$(dirname "${BASH_SOURCE[0]}")/.."

customCvoPullspec=quay.io/petr-muller/cluster-version-operator:"$(git branch --show-current)"

payload="$(oc get -n openshift-cluster-version clusterversion version -o jsonpath='{.status.desired.image}')"
podman pull "$payload"

LalatenduMohanty

$ oc get nodes -o yaml
apiVersion: v1
items:
- apiVersion: v1
  kind: Node
  metadata:
    annotations:
      csi.volume.kubernetes.io/nodeid: '{"pd.csi.storage.gke.io":"projects/openshift-gce-devel-ci/zones/us-central1-a/instances/ci-ln-sbbj2q2-f76d1-bh8mc-master-0"}'
      machine.openshift.io/machine: openshift-machine-api/ci-ln-sbbj2q2-f76d1-bh8mc-master-0
      machineconfiguration.openshift.io/currentConfig: rendered-master-d9ead9f63bf2dbd577f8508f4a7df772

LalatenduMohanty

I0701 11:41:49.366756  398972 config.go:128] looking for config.json at /home/lmohanty/.docker/config.json
I0701 11:41:49.366850  398972 config.go:136] found valid config.json at /home/lmohanty/.docker/config.json
I0701 11:41:49.367006  398972 round_trippers.go:425] curl -k -v -XGET  'https://quay.io/v2/'
I0701 11:41:49.580915  398972 round_trippers.go:445] GET https://quay.io/v2/ 401 Unauthorized in 213 milliseconds
I0701 11:41:49.580948  398972 round_trippers.go:451] Response Headers:
I0701 11:41:49.580957  398972 round_trippers.go:454]     Www-Authenticate: Bearer realm="https://quay.io/v2/auth",service="quay.io"
I0701 11:41:49.580971  398972 round_trippers.go:454]     Server: nginx/1.12.1
I0701 11:41:49.580978  398972 round_trippers.go:454]     Date: Thu, 01 Jul 2021 15:41:49 GMT
I0701 11:41:49.580987  398972 round_trippers.go:454]     Content-Type: text/html; charset=utf-8
I0701 11:41:49.580996  398972 round_trippers.go:454]     Content-Length: 4

LalatenduMohanty

apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfigPool
metadata:
  creationTimestamp: "2021-06-25T18:32:03Z"
  generation: 2
  managedFields:
  - apiVersion: machineconfiguration.openshift.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:spec:

LalatenduMohanty

Locate the section for your github remote in the .git/config file. It looks like this:

[remote "origin"]
	fetch = +refs/heads/*:refs/remotes/origin/*
	url = git@github.com:joyent/node.git

Now add the line fetch = +refs/pull/*/head:refs/remotes/origin/pr/* to this section. Obviously, change the github url to match your project's URL. It ends up looking like this:

LalatenduMohanty

$ make func-test 
Deploying Update Service operator
hack/deploy.sh
namespace/openshift-updateservice created
serviceaccount/updateservice-operator created
clusterrole.rbac.authorization.k8s.io/updateservice-operator created
rolebinding.rbac.authorization.k8s.io/updateservice-operator created
clusterrolebinding.rbac.authorization.k8s.io/updateservice-operator created
service/updateservice-operator-metrics created